Inconsistencies detected when cross-compiling #27
Comments
gcarreno
changed the title
|
Checked it myself ("real" or virtual systems, no cross-compiling):
|
|
Hey Werner(@wp-xyz), That's awesome!! Well, for the most of the "works fine" and "known issue" 😃 Could I ask you a favour and test my cross-compiled binaries please? corona-v1.0.0-i386-linux.tar.gz Thanks!!! BTW, I think we need a better communication line. What do you think about these option:
Cheers, |
… (Fix dropdown painting issue on macOS - github issue #27
* Set cmbDataType.Style to csDropDownList (instead of csOwnerDrawFixed). This fixes the dropdown painting issue on macOS (github isse #27)
All of them are working correctly: no download error, progressbars ok during download. Only the 32bit Linux version on my notebook had a hickup - saw the grid partly in black where the chart should be; download was ok, but when I clicked a treenode no chart was created; restarted the app and everything was ok. hard to reproduce. Could be that my notebook has some config issues. Maybe I put in another SSD and try to install Manjaro which is famous in our community for its up-to-date Lazarus, and it would expand my set of tools with a Linux more different from the Ubuntu world. I ran the 64bit version also in an old Ubuntu 16.04 - it has the drop-down color issue that was discussed in the forum some time ago: black text on back background... There's one minor issue in all versions: the About box displays a black square where the application icon should be. Probably because I removed the corona.res from the repo. Now i added the corona.res to be on the safe side. The most important issue, however, is Windows: not the program, but the OS. My antivirus system is the Microsoft Defender, and when I ran your exe it told me that I got infected by the Trojan:Script/Wacatac.B!ml trojan. I uploaded both exes to virustotal.com and only 1 out of 70 scanners reported the files to be unsafe. I never doubted that you'd send me a trojan, but I think this is a serious issue. When Defender, and probably all other scanners which are even more aggressive than Defender, see a program which performs a download from the internet, it "thinks" this program is going to download malware. I am unexperienced here, I never offered binaries in the internet. What we probably need is a certificate - no idea how to get one (I do not intend to pay anything for it) and how to modify the program such that it is respected... I made another commit which fixes the macOS painting issue with the dropdown. For some reason (left-over from an older version of the program?) the combobox style was selected as csOwnerDrawFixed. After changing it to csDropDownFixed everything is ok.
Hmmm, sorry, I'm not a fan of chatting. Too much distraction. |
|
Hey Werner(@wp-xyz), No issues on progress bar on allYAY, thanks!! Missing about iconIt has absolutely nothing to do with the The antivirus thingThanks for the leap of faith with the Windows binaries!! Well, this is unavoidable. There are many forums full of unresolved issues about this. Ubuntu 16.04I think that that one is WAY to old. We should test it with 18.04, since it's the before last LTS from 20.04. macOS painting issue solvedI'm glad that the fix was so easy!!! New issueThe dreaded DATES and formatting ARGGGGHHHH The chat thingMy intention on using a real time chat app is not to discuss the weather or ask what's your favourite colour. I understand your position and will respect it. Cheers, |
|
Am 20.02.2021 um 00:35 schrieb Gustavo Carreno:
The antivirus thing
What baffles me the most is that you don't get that issue when coding
in your windows box, only with linux cross-compiled windows binaries,
right?
Mainly I work on a "real" Windows 10 machine. Lazarus and all my project
folders are on the white list of the scanner. Linux etc run in a VM, and
Windows does not understand what is happening inside the VM. Now, in our
case I had a download from the internet - which is suspicious in the
first place. In case of an exe I am sure it would have told me that this
is a critical file and would have proposed not the run it, but there is
a small button on that dialog which allows me to run it nevertheless.
Here the exe was inside a zip and I started the exe out of the zip
(which was rather careless, yes) which is a bit of a different situation
and the scanner got active immediately. Maybe it would help if you could
create a setup file with inno setup. I could imagine that the "artifical
intelligence" of a virus scanner can be fooled this way...
*Ubuntu 16.04 *
I think that that one is WAY to old. We should test it with 18.04,
since it's the before last LTS from 20.04.
It has the same issue. I have a VM with 18.04, too. Only v20 is fine
New issue
The dreaded *DATES* and formatting *ARGGGGHHHH*
Windows, no issues:
corona-dates-windows
<https://user-images.githubusercontent.com/81799/108572533-68cc0380-730a-11eb-86a9-cd64d15e0a44.png>
Linux, issues:
corona-dates-linux
<https://user-images.githubusercontent.com/81799/108572548-72ee0200-730a-11eb-8945-4c81e9460be4.png>
You'll need to add a |FormatDatetime()| somewhere...
Dates shoule be handled in a locale independent way. Is it in the plot
of new cases vs cumulative (select it in the left/top combo)? I noticed
that today with the mapping branch. The program should handle dates in
its own format (cFormatSettings in unit cGlobal. As I noticed today,
procedure TMainForm.CrosshairDrawTool contains a ScanDateTime in the
dtCumVsNewCases branch of the "case dt of" in which this parameter
should be added at the end. Or another possibility is in the same
instruction because it uses a 2-digit year in the ScanDateTime while the
string was created with as a 4-digit year. Pull the current master, and
report what happens.
|
|
Hey Werner(@wp-xyz),
DUH!!! Imma so dumb!! Completely forgot about white listing...
I'm not sure it would.
Uuhh crap. Well, we'll put that on the warning, eheheh
They are! So I decided to go and have a look at how Ubuntu had the locale formatting. So disregard my dates issue. I was just under the impression that the Brits weren't this daft!! My opinion on this is that I just force I just noticed that I've caused you to run around like a headless chicken for two issues that are my complete fault. Cheers, |
|
Saw your message in my mail client before which did not show the attachments. I see now that you are talking about the dates in the grid. My "philosophy" behind date formatting is:
|
|
There is another issue with Windows: You plan to provide a setup.exe for Windows which "officially" installs corona into "c:\program files". corona, however, writes its download data as well as its cfg file into the exe directory. The folder "c:\program files", however, is read-only for normal users, and even admins will be interrupted by popping up CUA messages --> we must rewrite these routines to use the offical storage locations. |
|
Hey Werner(@wp-xyz),
Your philosophy is absolutely right. And if I was employed doing professional work, that's how I'd do it.
Yeah, I completely forgot about that change. I read about it recently, well ish, and it slipped my mind. So yeah, we will have to use If you'll allow me to suggest: var
DataFolder: String;
begin
{$IFDEF WINDOWS}
DataFolder:= GetUserDir+'CoronaData';
{$ELSE}
DataFolder:= GetUserDir+'.coronadata';
{$ENDIF}
end;Unless you're more inclined it being under %APPDATA% / Cheers, |
|
Returning to the "antivirus thing", I downloaded your win 32-bit zip again. However, this time i did not run the exe out of the zip, but extracted the zip into some directory and started corona.exe from there --> no issue! |
|
Hey Werner(@wp-xyz), That's rather odd. So what prompted the antivirus to bark at you in the other test? Cheers, |
|
Now I repeated exactly what I did the first time. Downloaded your zip again, opened it in PowerArchiver and ran the corona.exe from there - no issue this time. There were several antivirus updates since that event but in their release notes I cannot find anything indicating that this false alarm could have been fixed in the meantime. So, it remains to be rather mysterious. |
|
Hi Werner(@wp-xyz), Very mysterious indeed!! Cheers, |
|
Closing. |
Hey Werner(@wp-xyz),
I'm opening this issue primarily to list the inconsistencies and secondly for us to have a chat about it.
x86_64-linux:i386-linux:TComboBoxhas very squary corners and the rest of the UI is also strange.TProgressBar, onlyTLabel.lazbuildfrom trunk, as I'm building with stable 2.0.10 for releases. Maybe I have gremlins somewhere.x86_64-win64:i386-win32:This is where I'm at.
I have to admit that my cross-compiling now seems to be less healthy than I thought. Maybe need to refresh my stuff with a full install from
fpcupdeluxeon the cross-compile. Don has made some changes quite recently...Cheers,
Gus
The text was updated successfully, but these errors were encountered: