Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add RichText Control #1670

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Feat: Add RichText Control #1670

merged 2 commits into from
Dec 13, 2023

Conversation

theodesp
Copy link
Member

@theodesp theodesp commented Dec 5, 2023

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Adds a RichText control when the block attributes field has a source: "html" and selector definitions.

Related Issue(s):

Testing

Checkout the build and run blockset command on the block-support package:

$ npm run blockset -w examples/next/block-support

Navigate to the editor and create a block-b type. You should be able to use the new RichText field and mark the text using annotations(bold, italic) and be able to insert inline images. and so on.

Screenshots

Screenshot 2023-12-05 at 13 25 50 Screenshot 2023-12-05 at 13 25 46

Documentation Changes

Dependant PRs

@theodesp theodesp requested a review from a team as a code owner December 5, 2023 14:09
Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: 375cc80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustwp/block-editor-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 5, 2023

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 245.33 KB (🟢 -198 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 290 B 245.61 KB 70.18% (🟢 -0.01%)
/_error 193 B 245.52 KB 70.15% (+/- <0.01%)
/example 843 B 246.15 KB 70.33% (+/- <0.01%)
/preview 280 B 245.6 KB 70.17% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@theodesp theodesp merged commit 8dcda28 into canary Dec 13, 2023
18 checks passed
@theodesp theodesp deleted the MERL-1243 branch December 13, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants