Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example of proposed structure #1

Merged
merged 36 commits into from
Apr 14, 2020
Merged

example of proposed structure #1

merged 36 commits into from
Apr 14, 2020

Conversation

wcjochem
Copy link
Contributor

@wcjochem wcjochem commented Apr 6, 2020

The PR shows a proposed structure for the package and associated functions.

calculate_footstats() is a convenience wrapper function that would process a list of metrics and produce tabular or gridded output. The calculation functions should also be directly callable and add more flexibility to use pre-computed fields. S3 methods allow dispatch by different spatial data formats.

To-do: add a calculate_focal_footstats() for indexed or adjacent pixels; add a fasterize-based gridding function; expand metric calculations; add tests and documentation...

@wcjochem
Copy link
Contributor Author

wcjochem commented Apr 9, 2020

Updated branch now has all basic area and perimeter calculations. Should correctly handle units, but needs more testing, particularly with unprojected spatial data.

@doug-leasure
Copy link
Member

Awesome! Looks great. Sorry I was slow to see this. I've given everyone write access now.

@doug-leasure doug-leasure merged commit f3297e0 into master Apr 14, 2020
@wcjochem wcjochem deleted the dev_cj branch April 22, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants