Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct invalid geometries in building footprints #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

edarin
Copy link
Member

@edarin edarin commented Jun 20, 2022

Two suggested features:

  1. use st_make_valid
  2. output in verbose mode the number of tiles used for processing

@edarin edarin requested a review from wcjochem June 20, 2022 10:35
Comment on lines 534 to 536
if(any(sf::st_is_valid(Xsub) == F)){
suppressWarnings(Xsub <- sf::st_make_valid(Xsub))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea here. However, I think it might be better for this to be moved near R/calculate_footstats.R in . calculate_bigfoot calls calculate_footstats so by adding the fix there, anyone using calculate_footstats directly (for polygon area summaries) would also benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants