Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpilibc] Add C++ Notifier error handling, update java notifier error message #4795

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

rzblue
Copy link
Member

@rzblue rzblue commented Dec 11, 2022

No description provided.

@rzblue rzblue requested a review from a team as a code owner December 11, 2022 05:16
Starlight220
Starlight220 previously approved these changes Dec 11, 2022
Copy link
Member

@Starlight220 Starlight220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++?

@rzblue rzblue changed the title Update notifier error message, add link to frc-docs stacktraces page Add C++ Notifier error handling, update java notifier error message Dec 11, 2022
@rzblue
Copy link
Member Author

rzblue commented Dec 11, 2022

C++ didn't have any error reporting for Notifier, went ahead and added it based off of the try/catch in RobotBase

@rzblue rzblue changed the title Add C++ Notifier error handling, update java notifier error message [wpilibc] Add C++ Notifier error handling, update java notifier error message Dec 11, 2022
@PeterJohnson PeterJohnson merged commit 944dd72 into wpilibsuite:main Dec 12, 2022
@rzblue rzblue deleted the notifier-error branch December 19, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants