Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpiutil] Fix MemoryBuffer initialization #4797

Merged
merged 1 commit into from
Dec 11, 2022
Merged

[wpiutil] Fix MemoryBuffer initialization #4797

merged 1 commit into from
Dec 11, 2022

Conversation

rzblue
Copy link
Member

@rzblue rzblue commented Dec 11, 2022

Dereferencing an end iterator is undefined behavior and causes a failed assertion when running in debug.

@rzblue rzblue mentioned this pull request Dec 11, 2022
Merged
@rzblue rzblue changed the title Fix MemoryBuffer initialization [wpiutil] Fix MemoryBuffer initialization Dec 11, 2022
@sciencewhiz
Copy link
Contributor

I believe this should be a patch in upstream_utils rather then a change to the third party source.

@PeterJohnson
Copy link
Member

PeterJohnson commented Dec 11, 2022 •
edited
Loading

We don’t bring MemoryBuffer in from upstream_utils.

@PeterJohnson PeterJohnson merged commit 6948cea into wpilibsuite:main Dec 11, 2022
@rzblue rzblue deleted the memorybuffer-fix branch December 19, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzblue @sciencewhiz @PeterJohnson