Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to Hardware section #200

Closed

Conversation

benjamin-antupit
Copy link
Contributor

@benjamin-antupit benjamin-antupit commented Sep 20, 2019

See #40, #55 and #105.
Closes #285

Todo:

  • Add image source files (.ai) to images/source directories.
  • Update image of roboRIO in all illustrations
  • Resize illustrations to be compatable with imgconverter
  • Each new image <100 KB
  • Add image of wiring to pneumatics article
  • Rename image-1.svg and image-2.svg to mb1013-ultrasonic-sensor-to-roborio.svg
  • Add illustration and replace this image /hardware/hardware-basics/images/status-lights/rioLight.png
  • Replace roborio images /getting-started/getting-started-frc-control-system/images/imaging-your-roborio
  • Resize images on Preemptive Troubleshooting page
  • Resize images on coltrol-system-hardware page
  • Split into 4 PRs:
    1. Format hardware text and resize existing photos
    2. Add SVGs
    3. Fix up Status Light reference page
    4. Add info about IMUs

As always, suggestions are welcome and much appreciated.

@benjamin-antupit benjamin-antupit changed the title [WIP] Add details to Hardware section Add details to Hardware section Sep 22, 2019
@benjamin-antupit
Copy link
Contributor Author

@Daltz333 Can you review these changes?

@benjamin-antupit
Copy link
Contributor Author

benjamin-antupit commented Sep 22, 2019

Also, if anyone sees a good spot for more wiring diagrams for sensors or other components like the one below, please comment about it because I can make new ones for different components.
e4t-oem-miniature-optical-encoder-to-roborio-01
Edit: Thanks @Daltz333 for catching the reversed wiring!

Copy link
Member

@Daltz333 Daltz333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick review for now.

source/docs/hardware/sensors/gyros-hardware.rst Outdated Show resolved Hide resolved
source/docs/hardware/sensors/lidar.rst Outdated Show resolved Hide resolved
source/docs/hardware/sensors/sensor-overview-hardware.rst Outdated Show resolved Hide resolved
@Daltz333
Copy link
Member

Might want to edit that image a little bit. It's not completely accurate. Very pretty though.

@benjamin-antupit
Copy link
Contributor Author

benjamin-antupit commented Sep 27, 2019

@Daltz333 Thanks for catching the error in the image of encoder wiring. Please let me know if you have any suggestions on the other images I added/updated or anything else.

@benjamin-antupit
Copy link
Contributor Author

PRs #640, #641, #642, #643 and #644 supersede this PR. Please add comments or suggest changes to those PRs instead of this one.

@Daltz333 Daltz333 closed this May 7, 2020
@benjamin-antupit benjamin-antupit deleted the hardware-style branch May 18, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting On: Dependency Waiting on something from a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Sphynx imgconverter to convert .ai illustrations to .png files at compile time
5 participants