Add OpenGraph Support #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheTripleV
requested changes
Jul 1, 2020
|
Right now, with this PR, it isn't enough for chiefdelphi to make a preview using the OpenGraph data (but I'm not sure what is necessary). I'm guessing it's the image attribute. |
AustinShalit
reviewed
Jul 7, 2020
Co-authored-by: Austin Shalit <austinshalit@gmail.com>
|
The image has a transparent background. It would probably be best to have a non-transparent version for this, so the white text in WPI and FRC doesn't get lost. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AustinShalit
approved these changes
Jul 7, 2020
Starlight220
pushed a commit
to Starlight220/frc-docs
that referenced
this pull request
Aug 27, 2020
* Add Opengraph Extension * Use main site name * Update source/conf.py Co-authored-by: Austin Shalit <austinshalit@gmail.com> * Use WPILib logo Co-authored-by: Austin Shalit <austinshalit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #708