Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin activation message to direct users to settings page #112

Closed
raamdev opened this issue Apr 22, 2014 · 8 comments
Closed

Plugin activation message to direct users to settings page #112

raamdev opened this issue Apr 22, 2014 · 8 comments

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Apr 22, 2014

There should be a helpful plugin activation message that directs users to the settings page to configure/enable Quick Cache after activation.

@raamdev raamdev modified the milestones: Next Release, Future Release Apr 22, 2014
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Apr 28, 2014

Moving this to the Future Release milestone.

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Jun 18, 2014

Punting this to the Future Release milestone.

@raamdev raamdev modified the milestones: Future Release, Next Release Jun 18, 2014
@raamdev raamdev modified the milestones: Next Release, Future Release Aug 4, 2014
@raamdev raamdev modified the milestones: Next Release, Future Release Sep 23, 2014
@raamdev raamdev modified the milestones: Next Release, Future Release Nov 3, 2014
@raamdev raamdev modified the milestones: Next Release, Future Release Nov 25, 2014
@raamdev raamdev modified the milestones: Next Release, Future Release Dec 27, 2014
@raamdev raamdev modified the milestones: Next Release, Future Release Jan 21, 2015
@raamdev raamdev removed this from the Next Release milestone Mar 13, 2015
@raamdev raamdev modified the milestones: Future Release, Next Release May 16, 2015
@raamdev raamdev modified the milestones: Next Release (Pro), Future Release Jul 10, 2015
@raamdev raamdev modified the milestones: Next Release (Lite), Future Release (Lite) Sep 30, 2015
@raamdev raamdev modified the milestones: v151107 (Lite), Future Release (Lite) Nov 7, 2015
@jaswrks
Copy link

@jaswrks jaswrks commented Nov 12, 2015

Next Actions

  • New feature branch in the websharks/zencache-pro repo.

  • After this line add the following:

    'welcomed' => '0', // `0|1` welcomed yet?
    
  • After this line add the following:

    if (!$self->options['welcomed']) {
        $settings_url = add_query_arg(urlencode_deep(array('page' => GLOBAL_NS)), network_admin_url('/admin.php')));
        $self->enqueueMainNotice(sprintf(__('<strong>%1$s</strong> successfully installed! :-) Please <a href="%2$s">enable page caching</a> and configure options.', SLUG_TD), esc_html(NAME), esc_attr($settings_url), array('push_to_top' => true));
        $self->updateOptions(array('welcomed' => '1'));
    }
  • Submit PR.

kristineds added a commit to wpsharks/comet-cache-pro that referenced this issue Nov 15, 2015
kristineds added a commit to wpsharks/comet-cache-pro that referenced this issue Nov 15, 2015
@kristineds
Copy link

@kristineds kristineds commented Nov 15, 2015

@jaswsinc @raamdev I tried testing it on my demo site ~ encountered some parse errors but I fixed it (I think). I saw the activation message once but when I tried redoing it, I can't see it anymore. :( wpsharks/comet-cache-pro@786dff5

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Nov 16, 2015

@kristineds Try disabling Plugin Deletion Safeguards in ZenCache → Plugin Options → Plugin Deletion Safeguards and then deleting and uninstalling ZenCache. Then go in and install your modified version again.

It sounds to me like the welcomed option value got saved as 1, so you didn't see it show up again.

Let me know when you've run this through a successful test and I'll do some testing of my own. :-)

@kristineds
Copy link

@kristineds kristineds commented Nov 16, 2015

@raamdev Great! It works now! :) Submitting my PR for this. cc @jaswsinc

@raamdev raamdev modified the milestones: Next Release (Pro), Next Release (Lite) Nov 17, 2015
kristineds added a commit to wpsharks/comet-cache-pro that referenced this issue Nov 18, 2015
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Nov 18, 2015

Next Pro Release Changelog:

  • Enhancement: When activating ZenCache for the first time, a new Dashboard message now includes a helpful link to the options page to enable caching and review the options. Props @kristineds. See Issue #112.
@raamdev raamdev closed this Nov 18, 2015
@wpsharks wpsharks locked and limited conversation to collaborators Dec 21, 2015
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Dec 21, 2015

ZenCache Pro v151220 has been released and includes changes worked on as part of this GitHub Issue. See the release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#112).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants