Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Settings Link in Multisite Network #675

Closed
jaswrks opened this issue Feb 21, 2016 · 4 comments
Closed

Bug: Settings Link in Multisite Network #675

jaswrks opened this issue Feb 21, 2016 · 4 comments
Labels
Milestone

Comments

@jaswrks
Copy link

@jaswrks jaswrks commented Feb 21, 2016

2016-02-21_06-07-11

The settings link leads to an error when viewing the list of active plugins on the Main Site in a Network installation. I actually was not expecting to find ZenCache listed there at all, so a solution to this problem might be to simply exclude those additional links whenever is_multisite() && !is_network_admin()

Steps to Reproduce

  • Install on a MS Network installation and network activate.
  • Visit the Dashboard for the Main Site (not the Network Admin).
  • View the list of active plugins from the Main Site.
  • Click the [Settings] link.

Expected Behavior

That it would take me to the Network admin panel.

Observed Behavior

Permission denied, as a result of trying to load Settings on the Main Site instead of via the Network Admin panel.

@jaswrks jaswrks added the bug label Feb 21, 2016
@raamdev raamdev added the multisite label Feb 21, 2016
@raamdev raamdev added this to the Next Release (Pro); 1st CC Notice milestone Feb 21, 2016
@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 21, 2016

Confirmed fixed via wpsharks/comet-cache-pro@d640106.

2016-02-21_10-37-10

Also, it appears that the Multisite behavior changed in a recent WordPress update, as one of my Multisite test sites was running an older version of WordPress and ZenCache simply did not show up in the Main Site plugins list at all. Once I updated to the latest version of WordPress, all of the plugins that were Network Activated appeared in the Main Site plugins list.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 21, 2016

Next Lite Release Changelog:

  • Bug Fix (Multisite): Fixed a bug where when ZenCache was Network Activated the plugin settings link would show up in the plugins list for the Main Site and would lead to a 404 error. The settings link is now only shown when viewing the plugins list from the Network Admin. Props @jaswsinc. See Issue #675.
@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 21, 2016

Next Pro Release Changelog:

  • Bug Fix (Multisite): Fixed a bug where when ZenCache was Network Activated the plugin settings link would show up in the plugins list for the Main Site and would lead to a 404 error. The settings link is now only shown when viewing the plugins list from the Network Admin. Props @jaswsinc. See Issue #675.
@raamdev raamdev closed this Feb 21, 2016
@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 22, 2016

ZenCache v160222 has been released and includes changes from this GitHub Issue. See the v160222 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#675).

@wpsharks wpsharks locked and limited conversation to collaborators Feb 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants