TiVo Series 3 support: #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsing more or less works, but transfers to a TiVo Series 3 (or TiVo HD)
caused the TiVo to crash. Examination of transfers of the same file using
tivohmo and pyTivo showed this difference:
Query (from TiVo):
GET /TivoConnect?Command=QueryItem&Url=...
pyTivo:
HTTP/1.1 404 Not Found
tivohmo:
HTTP/1.1 200 OK
[...headers omitted for brevity...]
<?xml
version="1.0"
encoding="UTF-8"
?>
<QueryItem/>
It is unclear to me if my TiVos hate all QueryItem responses, or just null
responses (like above). Since there is nothing being returned anyway, this
commit removes support for QueryItem.
The result is that tivohmo matches pyTivo behavior now and my transfers
are successful.
|
Nice, good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsing more or less works, but transfers to a TiVo Series 3 (or TiVo HD)
caused the TiVo to crash. Examination of transfers of the same file using
tivohmo and pyTivo showed this difference:
Query (from TiVo):
GET /TivoConnect?Command=QueryItem&Url=...
pyTivo:
HTTP/1.1 404 Not Found
tivohmo:
HTTP/1.1 200 OK
[...headers omitted for brevity...]
It is unclear to me if my TiVos hate all QueryItem responses, or just null
responses (like above). Since there is nothing being returned anyway, this
commit removes support for QueryItem.
The result is that tivohmo matches pyTivo behavior now and my transfers
are successful.