-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pre-release and metadata #9
Conversation
The metadata feature is welcome. If I don't hear back from you before next weekend, I'll pull apart the PR and bring in the pre-release/metadata commit and leave the library changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no issues compiling or running this project and switching the library is unexpected in a PR that just mentions "updates dependencies" with no explanation of what the crash was, why change libraries, or anything. I have to reject this PR as a whole until that is explained or removed from the PR.
At the time
Might be joelself/tomllib#1 I mostly picked |
Can you make this PR solely about pre-release and metadata switches and remove anything to do with replacing the library? It is (in my opinion) poor form to include two very different things in a PR. Now that you've provided a problem case I can open an issue and we can see if |
I added the library as I couldn't test it otherwise. |
I'll be using your metadata/pre_release code as a starting point. Sorry I was suspicious about that library change. In the wake of what happened with dominictarr/event-stream#116 where a dependency was changed to attack a specific target and the lack detailed reasoning on the original PR left me unsure. I did switch to |
Also updates dependencies to not crash.
Fixes #8