Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Raw and selecting bracket param #515

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Conversation

v2ngu
Copy link
Contributor

@v2ngu v2ngu commented Jun 14, 2024

Two new parameters for extract brackets that work in tandem.

  • Find (list or str) of brackets to look for
  • Extract raw returns what was found raw
wrangles:
   - extract.brackets:
       input: Input A
       output: Output A
       find: 
            - curly
            - round
       extract_raw: true

@v2ngu v2ngu self-assigned this Jun 14, 2024
@v2ngu v2ngu linked an issue Jun 14, 2024 that may be closed by this pull request
Copy link
Contributor

@cerdamario13 cerdamario13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • rename extract_raw param to include_brackets. This gives more information as to what it does.
  • find param. Maybe rename to bracket_type? We can discuss with Thomas and Chris and see what they think

@cerdamario13 cerdamario13 merged commit 7924a89 into main Aug 12, 2024
33 checks passed
@cerdamario13 cerdamario13 deleted the improved-extract-brackets branch August 12, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extract.brackets Needs a Raw Param & Specify Bracket type
3 participants