Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling where clause error #519

Closed
wants to merge 11 commits into from
Closed

Handling where clause error #519

wants to merge 11 commits into from

Conversation

v2ngu
Copy link
Contributor

@v2ngu v2ngu commented Jun 14, 2024

Handles the error for the where clause only if the where returns an empty dataframe.

@v2ngu v2ngu added the bug Something isn't working label Jun 14, 2024
@v2ngu v2ngu self-assigned this Jun 14, 2024
@v2ngu v2ngu linked an issue Jun 14, 2024 that may be closed by this pull request
@ChrisWRWX
Copy link
Contributor

Closing this. On reflection, and following some discussions, it's not possible to solve this universally. By short circuiting it, the wrangles will never be executed and this will likely cause a following wrangle to fail in the common scenario that the output becomes the input of the next wrangle. If the code is simply skipped, the wrangle will not make the output column required.

This will instead be fixed by testing the wrangles to identify the ones currently failing and fixing them individually.

@ChrisWRWX ChrisWRWX closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where Filtering with exract.custom
2 participants