Add support for explicit attributes #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWIS methods like RankByCoutry returninig the list of countries with country-code as an attribute. To consume such api we need access to these attributes. To not break existing API we add an option for explicit attributes. Then We can access attributes with .attrs and xml element with .element
|
Addressed by #6 |
|
@knusul: thanks for the PR... and sorry I didn't review it earlier :-S Can you please check if the latest release addresses this correctly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWIS methods like RankByCoutry returninig the list of countries with
country-code as an attribute.
To consume such api we need access to these attributes.
To not break existing API we add an option for explicit attributes. Then
We can access attributes with .attrs and xml element with .element