-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for ICON in WPS #221
Conversation
… detection of the model
@grafmi Thanks for redoing this PR. I was able to compile the code, download the 0.6 deg ICON data using download_icon.sh, and run through ungrib, metgrid, real and wrf. I like that the Vtable included the GHT data from the model. This will provide a better estimate for input geopotential for the WRF model. I have a couple of quetions:
@mgduda @jimbresch If you would like to take a look at this, I have a couple of downloaded ICON data files on Cheyenne. Let me know. |
|
@mgduda @jimbresch Can you review this PR? Let's see if we can get it into v4.5 release. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see expanded comments at the bottom of the Vtable to better document the steps involved in running wps with ICON, but that could be added later. The code modifications seem fine.
@grafmi Do you mind making your download script available for others? |
@weiwangncar It's fine for me to make it available to others. Where should I provide it? |
@grafmi We may add a link in the release note for downloading the script, and we can also add it to our FAQs. Is there anything in the script you'd like to revise? Have you used it recently? It seems the data is update daily on the server and there is no archive of the data, correct? |
I was having issues with this version when using the It looks like something funky is happening with GEOPT:
Interestingly I did have success though when running with @WQadam's WPS:Support-for-DWD-suite-of-models from PR #220. |
Looks like GEOPT is missing from the metgrid.tbl in this PR, hence why it worked in mine but not this one. GEOPT should be added to the metgrid table like HGTT is in the metgrid table. |
@grafmi - This fixed the issue for me. Thanks for the help! |
I'm guessing it is alright to put GEOPT in the metgrid table like that. I see other vtables use GEOPT, mainly ecmwf. When running the EC and ERA5 models i see its needed to run calc_p_ecmwf before metgrid. I thought this was executable was mainly to calculate pressure which isnt needed for icon but i think this executable might also fill the lowest GEOPT level which metgrid is erroring on. |
@sael9740 There is no need to process GEOPT in metgrid since the model would not know what to do with it. The correct fix is to remove Geopotential in the row for GEOPT in Vtable.ICONp, like it is done in Vtable.ECMWF:
The ungrib program knows to compute HGT from GEOPT and write only HGT out in the intermediate file. Can you give it a try? |
@weiwangncar - Ya sure. I'll try that now and get back with you. |
@weiwangncar - Yes this worked. Just to be clear I used a22c073 as is with the exception that I removed the
|
Is WPS-V4.5 suitable for handling ICON global forecast data?(Data is downloaded here:https://opendata.dwd.de/weather/nwp/icon/grib) |
Yes it is! You have to do an additional step on download though to get it to a lat lon grid as WPS cant handle the icosahedral grid. Once set up the conversion is quick but can take a while to set up. I have run it from the model level version but i think you should be able to run it with the pressure levels aswell, however there isnt many pressure levels in the global model. see helpful links here on how to regrid icon global - |
Thank you so much! |
icon_download_modlv_global.txt See the download file above that is a shell script. I have had to put it as a text file to put it onto github. You will have to fill out the working directory and create your domain target text files and nc file by looking at the DWD help link in my previous comment. |
The ICON grib2 data set is now able to be ingested by the ungrib program. Informations about the ICON data set can be found here: https://www.dwd.de/DWD/forschung/nwv/fepub/icon_database_main.pdf
This PR has been tested with ICON-EU (~6.6 km resolution) data, but it should be able to run with ICON-D2 (~2.2 km resolution) and ICON-Global. For the latter it needs to be converted from an icosahedral grid to a regular lat-lon grid. Data for testing can be taken from PR #154
This PR is very similar to PR #220. Nevertheless I published it, so you can decide which one is more appropriate for your needs.