Skip to content
This repository has been archived by the owner on Oct 8, 2019. It is now read-only.

fix for #71 by replacing call to chunkifier with direct use of thrift API #141

Merged
merged 1 commit into from
Jul 19, 2012

Conversation

robinkraft
Copy link
Contributor

Implements this comment from issue #71, removing call to chunkifier in favor of using the thrift API directly and avoiding nullable !date field issue.

@danhammer
Copy link
Contributor

+1. short and important. nice. #shipit

@eightysteele
Copy link
Contributor

Nice dude. Only curiosity is why predicate/chunkify was originally a predicate macro. If that's not a problem, #shipit.

@robinkraft
Copy link
Contributor Author

chunkify has been around for ages, so it might have been needed as a predicate macro while using an earlier version of Cascalog. It's still used elsewhere, and it seems like this issue only comes up when !date is actually nil.

Merging.

robinkraft added a commit that referenced this pull request Jul 19, 2012
fix for #71  by replacing call to chunkifier with direct use of thrift API
@robinkraft robinkraft merged commit 97c86ff into develop Jul 19, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants