Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprint 2. Post comment form #14

Merged
merged 42 commits into from
May 18, 2020
Merged

Sprint 2. Post comment form #14

merged 42 commits into from
May 18, 2020

Conversation

IvanKomashniaP2H
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented May 7, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vizzuality1/gfw-blog-headless/3sixryrf5
✅ Preview: https://gfw-blog-headless-git-sprint-2post-comment-form.vizzuality1.now.sh

edbrett
edbrett suggested changes May 11, 2020
View reviewed changes
Copy link
Contributor

@edbrett edbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review:

  • submit does not work for me
  • padding of text area is incorrect
  • error in GFW's privacy policy link text. There are extra charachters
  • Font size or privacy statement too large
  • Submit button styles wrong way around

@edbrett edbrett merged commit c5edbc8 into develop May 18, 2020
@edbrett edbrett deleted the sprint-2_post-comment-form branch May 18, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbrett edbrett edbrett requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanKomashniaP2H @edbrett @pavlo-mohyla-p2h