436 smaller max width #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwampGuzzler
suggested changes
Jul 25, 2019
There was a problem hiding this comment.
@kaylakremer Our VegaChart.js in the Map is not being passed in a module prop, so they break when they try to grab properties off of that non-existent object in their render method!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#436
http://alpha.blueraster.io/gfw-mapbuilder/436-smaller-max-width/
@SwampGuzzler This is more than likely still a WIP. Once Richard updates the signals by not hardcoding heights and widths, then I can adjust the max-width on the div container wrapping each of the chart widgets accordingly to make it look nice. Right now, I just chose a
max-widthvalue of 500px for the badge charts to demonstrate thatmax-widthworks (see my conversation with Richard in the ticket!)Also, this will need to be merged into #396 which has now become the base branch for all resizing tickets!