Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing a couple of bugs on FAO people widgets #3378

Merged
merged 1 commit into from
Apr 25, 2018
Merged

fixing a couple of bugs on FAO people widgets #3378

merged 1 commit into from
Apr 25, 2018

Conversation

benlaken
Copy link
Contributor

Overview

  • 1990's were missing from the employment widget. Added it back in.
  • Changed default year from 2000 to 2010 for economic widget.
  • Created a whitelist to prevent the economic widget from appearing on pages where no data exists.

Tests

01painadam
01painadam approved these changes Apr 25, 2018
View reviewed changes
Copy link
Contributor

@01painadam 01painadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as it should!

@edbrett edbrett merged commit d9452c9 into develop Apr 25, 2018
@edbrett edbrett deleted the bugfix/fao_people_widgets branch April 25, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@01painadam 01painadam 01painadam approved these changes

@edbrett edbrett edbrett approved these changes

@pjosh pjosh Awaiting requested review from pjosh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benlaken @edbrett @01painadam