Feedback implementation #3461
Merged
Feedback implementation #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbrett
suggested changes
Jun 4, 2018
| @@ -7,10 +7,10 @@ export default { | |||
| size: 'small', | |||
| forestTypes: ['ifl_2013'], | |||
| landCategories: ['wdpa', 'landmark', 'mining'], | |||
| units: ['ha', '%'], | |||
| units: ['ha'], | |||
| @@ -6,10 +6,10 @@ export default { | |||
| size: 'small', | |||
| forestTypes: ['ifl_2013', 'plantations', 'primary_forest'], | |||
| landCategories: ['mining', 'wdpa', 'landmark'], | |||
| units: ['ha', '%'], | |||
| units: ['ha'], | |||
|
|
||
| const sentence = initial; | ||
| const params = { | ||
| location: currentLabel, | ||
| startYear, | ||
| endYear, | ||
| lossPhrase, | ||
| value: `${format('.3s')(totalOutsideLoss)}t of CO<sub>2</sub> emissions` | ||
| value: `${format('.3s')(outsideEmissions)}t`, | ||
| percentage: percentage < 0.1 ? '<0.1%' : `${format('.2r')(percentage)}%` |
There was a problem hiding this comment.
Shall we start using our format helper?
| @@ -62,6 +62,7 @@ export const getSentence = createSelector( | |||
| const params = { | |||
| year: settings.extentYear, | |||
| location: currentLabel || 'global', | |||
| location_alt: `${currentLabel}'s`, | |||
There was a problem hiding this comment.
Ideally when it comes to translations, this 's should be in the sentence so that it can be changed.
|
Made the changes! 👍 |
edbrett
suggested changes
Jun 5, 2018
| @@ -93,7 +94,7 @@ export const getSentence = createSelector( | |||
| endYear, | |||
| lossPhrase, | |||
| value: `${format('.3s')(outsideEmissions)}t`, | |||
| percentage: percentage < 0.1 ? '<0.1%' : `${format('.2r')(percentage)}%` | |||
| percentage: `${formatNumber({ num: percentage, unit: '%' })}` | |||
There was a problem hiding this comment.
You aren't generating a string here outside of the function so you just need to execute the helper, no need for the ` and $ :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Last round of feedback implementations.