Statistical Fires Widget #3462
Merged
Statistical Fires Widget #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01painadam
added
WIP
edbrett
reviewed
Jun 5, 2018
| @@ -0,0 +1,67 @@ | |||
| import React, { PureComponent } from 'react'; | |||
There was a problem hiding this comment.
As this is identical, could we import this into from the glads widget?
There was a problem hiding this comment.
Or even better make a new shared component in the /widgets/components folder?
There was a problem hiding this comment.
Yeah we definitely could.
| @@ -0,0 +1,296 @@ | |||
| import { createSelector } from 'reselect'; | |||
There was a problem hiding this comment.
How much has this file deviated from the GLADs? Could we map the fires data to the same structure in the action and then make this a helper? Or even just reuse it from GLADs?
There was a problem hiding this comment.
Yes, I think so - I just wanted to start from scratch first to find if there are many deviations from GLAD.
app/javascript/services/alerts.js
Outdated
| @@ -49,6 +54,22 @@ export const fetchGLADLatest = () => { | |||
| return request.get(url, 3600, 'gladRequest'); | |||
| }; | |||
|
|
|||
| export const fetchFiresAlerts = ({ country, region, subRegion }) => { | |||
benlaken
added
countries dashboard
and removed
AWAITING APPROVAL
WIP
…feature/refactor-fires-stats
feature/refactor-fires-stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Statistical fires widget! 🔥
Does the same as current GLAD widget... but for fire.
For now I've just duplicated the GLAD widget as a starting point. We can likely reduce the code significantly at a later date.
Cannot be implemented until we get the go ahead from Charlie that he's updating daily.
For now, it looks like this:
Notes
Known Issues
IOT, XCA, SPM, NFK, PIS, WLF require blacklisting
reloading the page (e.g. moving between countries) doesn't always trigger the chart to refresh correctly
start dates for each service/location are not the same! We will need a whitelist for which countries/services begin when.
currently no api service to get 'latest' date. Once data is updated daily we should be able to do this using
viirs-active-fires(minus 1 week to get the last full weeks worth of data)'dataset' selector not appearing in user settingsdata doesn't have zeroes when there are no alerts. That week/year is just missing.requires a palettethere is a bug here where the statistical bounds in the background are not translated correctly, need to investigateRequirements
Update
.envwith: