Feature/remove widget dependencies #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbrett
reviewed
Jul 18, 2018
| @@ -53,7 +52,9 @@ const mapStateToProps = ({ widgets, location }, ownProps) => { | |||
| const locationPath = `dashboards/${type || 'global'}/${locationUrl}`; | |||
| const widgetQuery = `widget=${widget}`; | |||
| const widgetState = | |||
| query && query[widget] ? `&${widget}=${query[widget]}` : ''; | |||
| query && query[widget] | |||
| ? `&${widget}=${btoa(JSON.stringify(query[widget]))}` | |||
There was a problem hiding this comment.
Ah ha! You should no longer need to do this. You can now find this state as a clean and tidy object on the location.query.widgets reducer in the store. You can use a selector to merge the props just like in the map!
There was a problem hiding this comment.
I don't do it to update the current url. Actually it's only for generate the share url that we need to pass to the EXPLORE ON GFW button on the embed view.
…lects feature/analysis-location-selects
…re/remove-widget-dependencies
…re/remove-widget-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.