Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANALYSIS]: Fixes loss & multiple analyses #3523

Merged
merged 6 commits into from
Jul 20, 2018
Merged

Conversation

01painadam
Copy link
Contributor

Overview

The hottest, dirtiest fix you'll see this year - guaranteed!

  • Fixes loss for country/adm shapes, custom shapes, wdpa, tcl - you name it!
  • Allows multiple layers to be analysed simultaneously in the above cases

Note: one issue remains...

When analysing GLAD, the api currently only returns 2000 extent, so switching between 2000 & 2010 is broken. Requires multiple fetches in this instance... but thats for another PR.

@@ -86,27 +86,51 @@ define(
}
}
});
console.log('UMD', umdResponse);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean up these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@edbrett edbrett merged commit 9f7a4e3 into develop Jul 20, 2018
@edbrett edbrett deleted the fix/analysis-wdpa branch July 20, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants