Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update staging api endpoints #3533

Merged
merged 4 commits into from
Aug 2, 2018
Merged

Update staging api endpoints #3533

merged 4 commits into from
Aug 2, 2018

Conversation

01painadam
Copy link
Contributor

@01painadam 01painadam commented Jul 31, 2018 •
edited
Loading

Overview

  • Staging now uses only staging api end points.
  • Analysis country/admin drop-downs go directly to CARTO tables (gadm36)

Note

Country drop downs not showing countries (data is fetched successfully)

@01painadam 01painadam added the WIP Any PR that should not be merged to develop label Jul 31, 2018
@01painadam 01painadam requested a review from edbrett July 31, 2018 13:57
@01painadam 01painadam added _DEVELOP staging Any PR expected to be kept on staging and removed WIP Any PR that should not be merged to develop _DEVELOP labels Aug 1, 2018
edbrett
edbrett reviewed Aug 1, 2018
View reviewed changes
app/assets/javascripts/map/services/CountryService.js Outdated
return new Promise(
function(resolve, reject) {
var url = new UriTemplate(URL).fillFromObject({ id: id });
console.log(URL);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean up here.

edbrett
edbrett approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@edbrett edbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. All running smoothly now. Very satisfying.

@edbrett edbrett merged commit b913a12 into develop Aug 2, 2018
@edbrett edbrett deleted the fix/staging-analysis branch August 2, 2018 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbrett edbrett edbrett approved these changes

Assignees
No one assigned
Labels
staging Any PR expected to be kept on staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@01painadam @edbrett