Fixed Tree Cover Pies #3571
Merged
Fixed Tree Cover Pies #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbrett
reviewed
Aug 28, 2018
| let plantations = 0; | ||
| let data = {}; | ||
| if (extent.length) { | ||
| totalArea = adminExtent[0].total_area; |
There was a problem hiding this comment.
You need to check admin response is defined here and below too otherwise it might crash the app.
edbrett
reviewed
Aug 28, 2018
| const plantationsData = | ||
| plantationsResponse.data && plantationsResponse.data.data; | ||
| plantations = plantationsData.length | ||
| ? plantationsData[0].value |
edbrett
reviewed
Aug 28, 2018
| plantationsResponse => { | ||
| const plantationsData = | ||
| plantationsResponse.data && plantationsResponse.data.data; | ||
| plantations = plantationsData.length |
There was a problem hiding this comment.
If you check for length on a undefined your gonna have a bad time.
edbrett
reviewed
Aug 28, 2018
| } | ||
| ]; | ||
| if (!indicator && hasPlantations) { | ||
| if (indicator) { | ||
| parsedData.splice(1, 0, { |
There was a problem hiding this comment.
Do we want to mutate the array?
edbrett
reviewed
Aug 28, 2018
| color: colors.otherCover, | ||
| percentage: otherCover / totalArea * 100 | ||
| }); | ||
| } else if (!indicator && hasPlantations) { | ||
| parsedData.splice(1, 0, { |
There was a problem hiding this comment.
This might need updating also.
edbrett
suggested changes
Aug 28, 2018
edbrett
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For any selected indicator (forest type / land category) the pies should show:
a) forest cover in that indicators polygon
b) forest NOT in that indicators polygon
c) Non-forest
e.g.
This fixes this and also introduces:
It also fixes other mathematical errors in calculating areas (see: mangroves)
Testing
Please test for indicator combination at iso/adm1/2 levels (Global not affected)