Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/timeline config in api #3595

Merged
merged 5 commits into from
Oct 4, 2018
Merged

Feature/timeline config in api #3595

merged 5 commits into from
Oct 4, 2018

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Oct 3, 2018

Overview

These contains three important updates:

  • fixes for the timelines to improve date formatting and steps/intervals.
  • move timeline config to the api and then to the selectors
  • improve all decode functions for all canvas layers

Demo

Check out the branch and play with the timelines for all the forest change layers.

benlaken
benlaken approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@benlaken benlaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me in local testing, great job! 🍻

@edbrett edbrett merged commit 138723f into feature/map-v2 Oct 4, 2018
@edbrett edbrett deleted the feature/timeline-config-in-api branch October 4, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlaken benlaken benlaken approved these changes

@01painadam 01painadam Awaiting requested review from 01painadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edbrett @benlaken