-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/responsive new map #3607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/responsive-new-map
…w into feature/responsive-new-map
…eature/map-routes
…eature/ptw-staging
…re/responsive-new-map
greysteil
reviewed
Oct 23, 2018
Gemfile
Outdated
@@ -38,7 +38,7 @@ gem 'webpacker', '~> 3.5.5' | |||
# http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#responders | |||
gem 'responders', '~> 2.0' | |||
|
|||
gem 'nokogiri', '~> 1.8.2' | |||
gem 'nokogiri', '~> 1.8.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to tweak this to be ~> 1.8.5
- there was a new security vulnerability announced in 1.8.4 a couple of weeks ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thanks!
edbrett
force-pushed
the
feature/responsive-new-map
branch
from
October 23, 2018 14:11
b6a2777
to
9a82949
Compare
check for env key for datasets
Feature/map routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Well clearly this boi hadn't heard of the power of React Responsive. The prodigal app [sic] GFW has returned and with it, it brings new powers. It is not only reactive, but now ALSO responsive. A feat rarely achieved by my mere mortals.
So how did these powers come to be? What specifically do its powers enable its users to do? What bullet point list of features can be defined to outline the exact changes it has gone through? Possibly this one:
Notes
ADDITIONAL fixes have been made due to the sheer complexity of this PR to embeds, layouts, CSS all over the metaphorical shop. Only side note is Terrai latest dates is now working again in the timeline.
Testing
Make a cup of tea, pull out your RESPONSIVE device of choice (ideally a standard issue iPad Pro with magic pen and 7D retina VR backflip soul port display), and start playing. Please report and bugs to @edbrett.