Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/responsive new map #3607

Merged
merged 59 commits into from
Oct 24, 2018
Merged

Feature/responsive new map #3607

merged 59 commits into from
Oct 24, 2018

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Oct 22, 2018

Overview

screen shot 2018-10-22 at 10 58 21

"When we ground ourselves in the present moment, we spontaneously connect better with others. We become more responsive and less reactive, listening more deeply and speaking with greater clarity.”
― Lama Surya Das, Buddha Standard Time: Awakening to the Infinite Possibilities of Now

Well clearly this boi hadn't heard of the power of React Responsive. The prodigal app [sic] GFW has returned and with it, it brings new powers. It is not only reactive, but now ALSO responsive. A feat rarely achieved by my mere mortals.

So how did these powers come to be? What specifically do its powers enable its users to do? What bullet point list of features can be defined to outline the exact changes it has gone through? Possibly this one:

  • Mobile map menu: this focuses around a panel based display. Opening the menu causes the panel to appear from the bottom of the screen. Possible panels include (Layers, Legend, Analysis, Explore, Search, Recent Imagery). Base maps has been moved to Layers for mobile.
  • Map controls has been reduced into a share and recent imagery button.
  • Header has a smaller logo to hide less of the map
  • Animations have been added to the panels for better interaction
  • Embed styles updated to hide unneeded panels and move menu to right side
  • Layers (datasets on desktop) can be accessed through a category menu on mobile with a navigation header on the panel.

Notes

ADDITIONAL fixes have been made due to the sheer complexity of this PR to embeds, layouts, CSS all over the metaphorical shop. Only side note is Terrai latest dates is now working again in the timeline.

Testing

Make a cup of tea, pull out your RESPONSIVE device of choice (ideally a standard issue iPad Pro with magic pen and 7D retina VR backflip soul port display), and start playing. Please report and bugs to @edbrett.

Gemfile Outdated
@@ -38,7 +38,7 @@ gem 'webpacker', '~> 3.5.5'
# http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#responders
gem 'responders', '~> 2.0'

gem 'nokogiri', '~> 1.8.2'
gem 'nokogiri', '~> 1.8.4'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to tweak this to be ~> 1.8.5 - there was a new security vulnerability announced in 1.8.4 a couple of weeks ago.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thanks!

@edbrett edbrett merged commit c801c07 into feature/map-v2 Oct 24, 2018
@edbrett edbrett deleted the feature/responsive-new-map branch October 26, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants