Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/bug fixes for bugs #3688

Merged
merged 3 commits into from
Jan 16, 2019
Merged

Fix/bug fixes for bugs #3688

merged 3 commits into from
Jan 16, 2019

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Jan 16, 2019

Hotfixes for:

  • HMR not completely covered for state() cases
  • fill on new svg preventing white fill on mobile
  • analysis panel crashing app in mobile due to infinite rerender from datasets selectors

To test:

  • load app in mobile view and make analysis
  • check mobile icons for datasets
  • HMR shouldn't crash app when viewing analysis and making a change

@edbrett edbrett added the hotfix Urgent fixes to production bugs label Jan 16, 2019
@edbrett edbrett requested a review from dfrico January 16, 2019 11:15
dfrico
dfrico approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@dfrico dfrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected (apart from unrelated issue when drawing analysis shapes).

@edbrett edbrett merged commit 180704a into develop Jan 16, 2019
@edbrett edbrett deleted the fix/bug-fixes-for-bugs branch January 16, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfrico dfrico dfrico approved these changes

Assignees
No one assigned
Labels
hotfix Urgent fixes to production bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edbrett @dfrico