Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/recent imagery interactions update #3691

Merged
merged 13 commits into from
Feb 8, 2019
Merged

Feature/recent imagery interactions update #3691

merged 13 commits into from
Feb 8, 2019

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Jan 22, 2019

Overview

We have several updates for interactivity on the recent imagery feature of the map:

  • always have control panel open when active
  • add a loader message to tell user when fetching recent image
  • move loader to map instead of button
  • remove tile tooltip and hover click interactions
  • collapsable panel for mobile when active

Also includes some improvements for the loading of the tiles.

Testing

  • active the tool, moving around the map to get new tiles
  • deactivate the tool and make sure panel clears and tiles clear from map
  • open in mobile, activating and opening and closing the panel

@edbrett edbrett added the staging Any PR expected to be kept on staging label Jan 22, 2019
@edbrett edbrett requested a review from dfrico January 22, 2019 10:51
dfrico
dfrico approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@dfrico dfrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on desktop and mobile

@edbrett edbrett added the develop Any PR that is ready to be merged to develop label Feb 8, 2019
@edbrett edbrett merged commit 1846f45 into develop Feb 8, 2019
@edbrett edbrett deleted the feature/recent-imagery-interactions-update branch February 8, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfrico dfrico dfrico approved these changes

Assignees
No one assigned
Labels
develop Any PR that is ready to be merged to develop staging Any PR expected to be kept on staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edbrett @dfrico