Skip to content

Use collection.url rather than server + collection alias in share sheets #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2021
Merged

Use collection.url rather than server + collection alias in share sheets #180

merged 1 commit into from
Apr 7, 2021

Conversation

AngeloStavrow
Copy link
Collaborator

Closes #179.

@AngeloStavrow AngeloStavrow added ios Anything specific to the iPhone/iPad app mac Anything specific to the Mac app labels Mar 18, 2021
@AngeloStavrow AngeloStavrow requested a review from thebaer March 18, 2021 19:50
@AngeloStavrow AngeloStavrow self-assigned this Mar 18, 2021
thebaer
thebaer approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after reading through!

@AngeloStavrow AngeloStavrow merged commit 94c875b into main Apr 7, 2021
@AngeloStavrow AngeloStavrow deleted the use-collection-url-for-share-sheet branch April 7, 2021 14:59
@AngeloStavrow AngeloStavrow added this to the 1.0 milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebaer thebaer thebaer approved these changes

Assignees

@AngeloStavrow AngeloStavrow

Labels
ios Anything specific to the iPhone/iPad app mac Anything specific to the Mac app
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Use collection URL for share sheet rather than instance server
2 participants
@AngeloStavrow @thebaer