Persist logged-in state between app launches #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8.
This PR handles persistence for logged-in state in two ways.
Via the Keychain
When logging in, the user's access token is saved to the Keychain; when logging out, that Keychain entry is destroyed. A helper method for fetching the token is also part of this work; all Keychain helpers live in the WriteFreelyModel extension.
Via UserDefaults
For non-sensitive data, we also want to persist state so that we can fetch tokens from the Keychain between app launches (since the WF client, which has a user property, is only kept in-memory). We therefore persist the
isLoggedIn,server, andusernameproperties in UserDefaults, and restore these values on launch.