Codehighlight, add support for all languages #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dynamically construct a list of languages to load - fire hightlighting once last file has loaded
* upstream/master: Re-add https in log message Also use bind address on standalone redirect Allow 'bind' in config to specify bind address Only log ActivityPub info when debugging Bump version to 0.4 Move softwareVer to var() block Add @koehn to AUTHORS Add `make release-docker` Move docker build to `make build-docker` extracted docker command a la `go` and `make` added docker support to `make release` removed an unnecessary debugging statement added .git to make builds cache more effectively and run faster switched to much smaller alpine image since golang not required at runtime Updated Dockerfile to produce smaller image with minimum content and a few extra features; added .dockerignore
|
Anything needed here? From my POV this can be merged. The only ugly thing is the static assignment of the common set, but that will disappear once we go local js and make the default load without any languages. |
|
Nope, this looks great! Nicely done. And I agree on the optimizations with moving to local JS / reducing what languages are loaded by default. That'd be a great thing to tackle next. Merging now; will include these changes in v0.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for all highlightjs supported languages.
It determines upfront what js files should be loaded, does that and triggers a highlight on the last one loaded. While we are on the CDN, the common set will still be loaded, so we can be leaner once we go local js and only load the languages we need.