-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.11.2 hotfix #224
Merged
Merged
v0.11.2 hotfix #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this check would return a "user not found" error when retrieving a collection post by its post ID, e.g. /api/posts/abc123 instead of /api/collections/demo/posts/my-slug -- this happens particularly when `Announce`ing a post in the fediverse. This change fixes that.
Previously, fetching ActivityStreams data about a post via /api/posts/ID, instead of /api/collections/ALIAS/posts/SLUG wouldn't include the instance's base URL. This fixes that.
Fix suspension check in fetchPost()
Fix fediverse post IDs
This adds the instance's Hostname to the collection data loaded when editing a collection post or its metadata. While not technically needed in this situation, it suppresses an alarming error log. Resolves #216
Fixed "user-supsended" to "user-suspended"
Use "silenced" phrasing instead of "suspended"
Suppress log when editing a collection post or its metadata
Previously, any password-protected collection on a suspended account would prompt visitors for a password, and *then* take them to the "not found" page. This fixes that.
Logged-in users never see this particular page, so it's not needed here.
a user who had previously authenticated on a protected collection would still see the post after the owner was silenced, with a banner meant for the owner displayed.
This also saves a user suspension check when a post isn't found.
Fix password-protected page template
Prevent failed requests on failed user silence check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.11.2
User-Facing Changes / Fixes
Announce
ing posts via ActivityPub (Fix suspension check in fetchPost() #212)id
property in collection posts ActivityStreams data (Fix fediverse post IDs #214)