Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Attachment shortcut not working #209

Closed
welpdx opened this issue Nov 10, 2021 · 3 comments
Closed

Rename Attachment shortcut not working #209

welpdx opened this issue Nov 10, 2021 · 3 comments

Comments

@welpdx
Copy link

welpdx commented Nov 10, 2021

Issue description

After I add a shortcut config to Rename Attachment, the shortcut doesn't work. Other shortcuts do work.

Steps to reproduce the issue

  1. Tools -> Zutilo Preferences... -> Shortcuts
  2. Scroll down to Rename Attachments (category: Attachments) -> add any shortcut that isnt used before
  3. Apply -> OK -> click on parent
  4. Using the shortcut doesn't work

What's the expected result?

I expect it to rename the attached pdf file name.

What's the actual result?

Nothing happens

Additional info

Zotero 5.0.96.3
Add-ons installed"

  • mdnotes 0.1.3
  • ZotFile 5.0.16
  • Better BibTex 5.6.8
  • Zutilo 3.10.0

What fix did you try?

The shortcuts that are working (for e.g., Alt + Ctrl + C), I disabled that Zutilo shortcut and used that shortcut for Rename Attachments... didn't help

@welpdx
Copy link
Author

welpdx commented Nov 10, 2021

nvm. I should be changing the shortcut for "Move and rename attachments" not "Rename Attachments"

@welpdx welpdx closed this as completed Nov 10, 2021
@qqobb
Copy link
Collaborator

qqobb commented Nov 11, 2021

Yes, if you're using ZotFile, use "Move and rename attachments", not "Rename attachments".

  • The shortcut "Move and rename attachments" uses ZotFile's function, which is accessible in the item's context menu through "Manage Attachments" -> "Rename".

  • The shortcut "Rename attachments" uses Zotero's function, which is accessible in the item's context menu as "Rename File From Parent Metadata".

The shortcut for Zotero's function only works if you also get the "Rename File From Parent Metadata" option when right-clicking the selected items. You only get this option if you select attachments without their parent items. To select all PDF files, use a saved search as explained here. Alternatively, use Quick Search to select all PDF files in the current view:

  1. Quick Search ("All Fields & Tags"): .pdf.
  2. Select one item.
  3. "Edit" -> "Select All" (or Ctrl+A).

ZotFile's renaming function is much more flexible, but it currently can't rename linked files without moving them, see here.

@welpdx
Copy link
Author

welpdx commented Nov 12, 2021

Hey @qqobb, thanks for the extra details! I didn't realize that 1) ZotFile can't rename linked file w/o moving them, and 2) one should use "Rename File From Parent Metadata" when selecting the pdfs (not parent items). Not a seriously big issue but it is good to know all this. Thanks for writing all this out! I'm def saving your comment for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants