Fix EI-2347 #983
Merged
Fix EI-2347 #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes thread death when unsubscribing a subscription from UI. The underlying cause was a dead lock in the disruptor that occured when the DB recovery task runs. The DB recovery event(a disruptor event) detects conflicts of the connected node of local subscriptions and susbscriptions stored in the databse. Once a conflict is detected it disonnects the local subscription resulting in an event being published to the disruptor. This causes all disruptor handlers to hang thus MB being barely usable. The resolution for this is decouple the local subscription being deleted from the detection of the conflict. Resolves: wso2/product-ei#2347
sdkottegoda
force-pushed
the
fix_ei-2347_public
branch
from
e647814
to
c28a735
Compare
a5anka
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes thread death when unsubscribing a subscription from UI.
Resolves: wso2/product-ei#2347
Approach
The underlying cause was a dead lock in the disruptor that occured when the DB recovery task runs. The DB recovery event(a disruptor event) detects conflicts of the connected node of local subscriptions and susbscriptions stored in the databse. Once a conflict is detected it disonnects the local subscription resulting in an event being published to the disruptor. This causes all disruptor handlers to hang thus MB
being barely usable. The resolution for this is decouple the local subscription being deleted from the detection of the conflict.