Fix issues in authorization #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permission for queue consume is granted during the binding authorization. The issue was caused due to the fact that the permission check for binding was done after adding the binding. This existence of the incorrect binding causes the next consume call to be directly checked for autherization skipping necessary permission granting in binding creation. Resolves: wso2/product-ei#2631 Adds a configuration to skip permission check when processing basic consume for durable subscriptions to be compatible with the functionality of MB 3.0.0.
A user is granted permission to consume from a queue upon being authorized for the binding. Authorization for binding only happens for a new binding. The second user with the same subscription id is not granted permission to consume from the queue since binding authorization is skipped.
malakaganga
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Permission for queue consume is granted during the binding
authorization. The issue was caused due to the fact that the permission
check for binding was done after adding the binding. This existence of
the incorrect binding causes the next consume call to be directly
checked for autherization skipping necessary permission granting
in binding creation.
Resolves: wso2/product-ei#2631
A user is granted permission to consume from a queue upon being authorized for the binding. Authorization for binding only happens for a new binding. The second user with the same subscription id is not granted permission to consume from the queue since binding authorization is skipped.
Resolves: wso2/product-ei#2603