[CP] Add Thumbnail support for the API #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
==========================================
+ Coverage 33.55% 33.91% +0.36%
==========================================
Files 350 174 -176
Lines 39235 19813 -19422
Branches 12312 6267 -6045
==========================================
- Hits 13164 6720 -6444
+ Misses 25831 12973 -12858
+ Partials 240 120 -120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chashikajw
force-pushed
the
thumbnail-support
branch
from
681dcdb
to
3e575e3
Compare
| @@ -62,12 +62,17 @@ service /api/am/backoffice on ep0 { | |||
| } | |||
| return apiDefinition; | |||
| } | |||
|
|
|||
| isolated resource function get apis/[string apiId]/thumbnail(@http:Header string? 'if\-none\-match, @http:Header string? accept = "application/json") returns http:Response|commons:APKError { | |||
There was a problem hiding this comment.
shall we add them to the same level as previous commented out methods, otherwise with open-api bal gen command again these methods location will change
| @@ -232,6 +232,9 @@ dependencies = [ | |||
| {org = "ballerina", name = "jballerina.java"}, | |||
| {org = "ballerina", name = "lang.int"} | |||
| ] | |||
| modules = [ | |||
There was a problem hiding this comment.
add these same changes to dependencies.template.toml file as well
| @@ -24,6 +24,7 @@ import ballerina/io; | |||
| import wso2/apk_common_lib as commons; | |||
| import ballerina/log; | |||
|
|
|||
|
|
|||
chashikajw
changed the title
chashikajw
force-pushed
the
thumbnail-support
branch
3 times, most recently
from
b660f92
to
6683eae
Compare
chashikajw
force-pushed
the
thumbnail-support
branch
from
6683eae
to
688d63d
Compare
CrowleyRajapakse
previously approved these changes
May 12, 2023
CrowleyRajapakse
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This will add the thumbnail support for the API
This will implement the following resources in back office and devportal ds.
Backoffice
Devportal
Fixes