Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API CR validations #583

Merged
merged 6 commits into from
Feb 2, 2023
Merged

Conversation

AmaliMatharaarachchi
Copy link
Contributor

@AmaliMatharaarachchi AmaliMatharaarachchi commented Jan 31, 2023

Purpose

Fixes #610

  • improve API CR validations
  • change api type from HTTP to REST

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 32.05% // Head: 32.21% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (89c20ad) compared to base (ddd2e1b).
Patch coverage: 45.61% of modified lines in pull request are covered.

❗ Current head 89c20ad differs from pull request most recent head 8582b56. Consider uploading reports for the commit 8582b56 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   32.05%   32.21%   +0.16%     
==========================================
  Files         131      131              
  Lines       14137    14148      +11     
  Branches     4114     4114              
==========================================
+ Hits         4531     4558      +27     
+ Misses       9512     9496      -16     
  Partials       94       94              
Impacted Files Coverage Δ
.../internal/operator/apis/dp/v1alpha1/api_webhook.go 29.90% <43.63%> (+24.69%) ⬆️
...ime/runtime-domain-service/ballerina/APIClient.bal 52.15% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Amila-Rukshan
Amila-Rukshan previously approved these changes Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CR validations for API field formats
4 participants