Unit tests for APIPublisherImpl #3869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamilaadhi
requested changes
Mar 23, 2017
| @@ -150,7 +151,7 @@ public static LifecycleState getMockLifecycleStateObject(String lifecycleId) { | |||
| LifecycleState lifecycleState = new LifecycleState(); | |||
| lifecycleState.setLcName("API_LIFECYCLE"); | |||
| lifecycleState.setLifecycleId(lifecycleId); | |||
| lifecycleState.setState("PUBLISH"); | |||
| lifecycleState.setState("PUBLISHED"); | |||
There was a problem hiding this comment.
Use APIStatus constants
chamilaadhi
requested changes
Mar 23, 2017
| @@ -150,7 +151,7 @@ public static LifecycleState getMockLifecycleStateObject(String lifecycleId) { | |||
| LifecycleState lifecycleState = new LifecycleState(); | |||
| lifecycleState.setLcName("API_LIFECYCLE"); | |||
There was a problem hiding this comment.
use APIMgtConstants.API_LIFECYCLE
|
Thanks for the review. Will do changes. |
chamilaadhi
approved these changes
Mar 24, 2017
|
There are some strings constants in SampleTestObjectCreator.java class (not coming from your PR) . Shall we move them to constants and use existing constants where we can |
|
Yes, sure. I will move them. |
pubudu538
requested changes
Mar 24, 2017
| @@ -20,11 +20,13 @@ | |||
|
|
|||
| package org.wso2.carbon.apimgt.core; | |||
|
|
|||
|
|
|||
| import org.apache.commons.collections.map.HashedMap; | |||
There was a problem hiding this comment.
Shall we remove the new line?
|
Thanks for the review. Will rebase the code. |
pubudu538
approved these changes
Mar 27, 2017
mushthaq33
pushed a commit
to mushthaq33/carbon-apimgt
that referenced
this pull request
Nov 23, 2018
mushthaq33
pushed a commit
that referenced
this pull request
Nov 28, 2018
wso2-jenkins-bot
added a commit
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.