-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor XACML Registry implementation #5817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoshani
force-pushed
the
reg-imp
branch
11 times, most recently
from
July 30, 2024 03:15
4ef048b
to
752e6c6
Compare
darshanasbg
reviewed
Jul 30, 2024
.../src/main/java/org/wso2/carbon/identity/entitlement/policy/store/DefaultPolicyDataStore.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/wso2/carbon/identity/entitlement/policy/store/DefaultPolicyDataStore.java
Show resolved
Hide resolved
darshanasbg
reviewed
Jul 30, 2024
...tlement/src/main/java/org/wso2/carbon/identity/entitlement/policy/store/PolicyDataStore.java
Outdated
Show resolved
Hide resolved
PR builder started |
PR builder completed |
Yoshani
changed the title
Refactor xacml registry impl
Refactor XACML Registry implementation
Jul 31, 2024
darshanasbg
reviewed
Jul 31, 2024
...ent/src/main/java/org/wso2/carbon/identity/entitlement/internal/EntitlementConfigHolder.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Jul 31, 2024
...ent/src/main/java/org/wso2/carbon/identity/entitlement/internal/EntitlementConfigHolder.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Jul 31, 2024
...identity.entitlement/src/main/java/org/wso2/carbon/identity/entitlement/EntitlementUtil.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Jul 31, 2024
...ntitlement/src/main/java/org/wso2/carbon/identity/entitlement/dao/RegistryPolicyDAOImpl.java
Show resolved
Hide resolved
darshanasbg
reviewed
Jul 31, 2024
...titlement/src/main/java/org/wso2/carbon/identity/entitlement/pap/EntitlementAdminEngine.java
Outdated
Show resolved
Hide resolved
darshanasbg
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Refactors the xacml registry impl code. Following changes are incorporated:
PolicyDataStore
since removing this was not an informed decision.PolicyStoreManageModule
interface for backward compatibility.Related issues
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation