This repository has been archived by the owner on Feb 5, 2021. It is now read-only.
Add STS namespace for issuer #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,7 +101,11 @@ public static String getPrettyPrintJson(Map<String, String> attributes) { | |||
| */ | |||
| public static String getIssuerName(String cellName) { | |||
|
|
|||
| return cellName + "--sts-service"; | |||
| if (cellName.equals("composite")) { | |||
There was a problem hiding this comment.
There is an already existing constant for this. Can we reuse this ?
| @@ -156,7 +156,7 @@ public void testIsWorkloadExternalToCellery(String workload) throws Exception { | |||
| @Test | |||
| public void testGetIssuerName() throws Exception { | |||
|
|
|||
| Assert.assertEquals(CellStsUtils.getIssuerName("hr"), "hr--sts-service"); | |||
| Assert.assertEquals(CellStsUtils.getIssuerName("hr"), "hr--sts-service.default"); | |||
There was a problem hiding this comment.
Can we use the constants we defined ?
| @@ -101,7 +101,11 @@ public static String getPrettyPrintJson(Map<String, String> attributes) { | |||
| */ | |||
| public static String getIssuerName(String cellName) { | |||
|
|
|||
| return cellName + "--sts-service"; | |||
| if (cellName.equals(Constants.COMPOSITE_CELL_NAME)) { | |||
| return cellName + Constants.STS_SERVICE + "." + Constants.SYSTEM_NAMESPACE; | |||
There was a problem hiding this comment.
Can we use StringBuilder for these concatenation ? It will be better.
hasinthaindrajee
approved these changes
Oct 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose