Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update including logic of ProductHeader and ProductFooter #3956

Merged
merged 7 commits into from
Jun 26, 2023

Conversation

Yoshani
Copy link
Contributor

@Yoshani Yoshani commented Jun 23, 2023

Purpose

Currently the product-title.jsp and product-footer.jsp can only be included from a global location. This PR updates the including logic of relevant jsp files to facilitate including them tenant-wise or app-wise.

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

brionmario
brionmario previously approved these changes Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants