Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for m2m applciation feature #6452

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

asha15
Copy link
Contributor

@asha15 asha15 commented Jun 14, 2024

Purpose

Related Issues

  • $subject

Related PRs

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@wso2-jenkins-bot
Copy link
Contributor

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.


it("<MinimalAppCreateWizard /> renders without exploding", () => {
render(<MinimalAppCreateWizard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

import { ApplicationManagementConstants } from "../../../constants/application-management";
import { MinimalAppCreateWizard } from "../minimal-application-create-wizard";

describe("Test if the Branding page is working as expected", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
describe("Test if the Branding page is working as expected", () => {
describe("Test if the application create wizard is working as expected", () => {

Comment on lines +30 to +33
title = "m2m_application"
closeWizard = { jest.fn() }
addProtocol = { false }
templateLoadingStrategy = { ApplicationManagementConstants.DEFAULT_APP_TEMPLATE_LOADING_STRATEGY }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title = "m2m_application"
closeWizard = { jest.fn() }
addProtocol = { false }
templateLoadingStrategy = { ApplicationManagementConstants.DEFAULT_APP_TEMPLATE_LOADING_STRATEGY }
title="M2M Application"
closeWizard={ jest.fn() }
addProtocol={ false }
templateLoadingStrategy={ ApplicationManagementConstants.DEFAULT_APP_TEMPLATE_LOADING_STRATEGY }

@pavinduLakshan
Copy link
Contributor

pavinduLakshan commented Jun 15, 2024

Let's also add another unit test to validate that

  • the M2M app creation and navigating to the edit page of the created m2m application.
  • the shared access tab is hidden from UI in a created M2M app

@pavinduLakshan pavinduLakshan changed the title Add a unit test for m2m applciation Add unit tests for m2m applciation feature Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants