Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): add Header component #5

Merged
merged 24 commits into from
Feb 13, 2023
Merged

feat(react): add Header component #5

merged 24 commits into from
Feb 13, 2023

Conversation

savindi7
Copy link
Contributor

@savindi7 savindi7 commented Feb 2, 2023 •
edited
Loading

Purpose

Add custom components TopNavigation and UserDropdownMenu.

Wrap the components,

  • Avatar
  • Image
  • Menu

Related Issues

Related PRs

  • N/A

Checklist

  • UX/UI review done on the final implementation.
  • Story provided. (Add screenshots)
  • Manual test round performed and verified.
  • Unit tests provided. (Add links if there are any)
  • Documentation provided. (Add links if there are any)

Security checks

@savindi7 savindi7 changed the title chore(react): introduce header component chore(react): introduce Top Navigation component Feb 9, 2023
brionmario
brionmario previously approved these changes Feb 10, 2023
View reviewed changes
thivi
thivi previously approved these changes Feb 10, 2023
View reviewed changes
brionmario
brionmario previously approved these changes Feb 13, 2023
View reviewed changes
@savindi7 savindi7 changed the title chore(react): introduce Top Navigation component feat(react): introduce Top Navigation component Feb 13, 2023
@savindi7 savindi7 changed the title feat(react): introduce Top Navigation component feat(react): introduce Header component Feb 13, 2023
@brionmario brionmario changed the title feat(react): introduce Header component feat(react): add Header component Feb 13, 2023
@savindi7
Copy link
Contributor Author

Build and Lint locally verified.

Screenshot 2023-02-13 at 16 57 22

Screenshot 2023-02-13 at 16 57 30

@savindi7 savindi7 merged commit 3bf67a4 into wso2:main Feb 13, 2023
This was referenced Feb 13, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyoobAboosalih AyoobAboosalih AyoobAboosalih left review comments

@brionmario brionmario brionmario approved these changes

@thivi thivi thivi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savindi7 @thivi @brionmario @AyoobAboosalih