Fix Java installation flow #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pubudu538
approved these changes
Jun 5, 2017
anuruddhal
approved these changes
Jun 5, 2017
This was referenced Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Java manifest in the base module from a Puppet class to a Puppet defined type. This avoids having hard coded values as before and allows them to be passed from the caller manifest.
Furthermore, it also introduces and new Hieradata key to control the JDK installation.
Setting this to
falsewill result in JDK not being added by Puppet. The default value istrueset in thewso2/commonHiera file.This resolves #16 and #18.