Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC samples apps reveal authorization code in home page #131

Closed
Kavindu-Dodan opened this issue Nov 15, 2018 · 0 comments
Closed

OIDC samples apps reveal authorization code in home page #131

Kavindu-Dodan opened this issue Nov 15, 2018 · 0 comments

Comments

@Kavindu-Dodan
Copy link
Contributor

Description:
OIDC apps use authorization code flow. In this flow, response is handled by a servlet. Once redirect is validated, servlet dispatch home.jsp. Obtaining of token happens through jsp code that are embedded in the jsp page. This will reveal the authorization code in the URL, which is not appropriate.

This is a bug that needs to be fixed

Suggested Labels:
Bug, Improvements

Suggested Assignees:
kavindud@wso2.com
Kavindu-Dodan added a commit to Kavindu-Dodan/samples-is that referenced this issue Nov 15, 2018
@Kavindu-Dodan
Finalizing fixes for bug wso2#131
3e372b7
@Kavindu-Dodan Kavindu-Dodan mentioned this issue Nov 15, 2018
Merged
pulasthi7 added a commit that referenced this issue Nov 27, 2018
@pulasthi7
Merge pull request #132 from Kavindu-Dodan/kado/url-fix
761bb55 
Fixing issue #131 - correcting authorization code reveal on home page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kavindu-Dodan