Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't need "calculated variables" to be calculated every time we create project card. #81

Closed
e-lo opened this issue Jun 10, 2020 · 3 comments
Closed

Don't need "calculated variables" to be calculated every time we create project card. #81

e-lo opened this issue Jun 10, 2020 · 3 comments
Assignees
@e-lo @i-am-sijia
Labels
question Further information is requested

Comments

@e-lo
Copy link
Collaborator

e-lo commented Jun 10, 2020

I'm wondering if we need to create the calculated variables?
We shouldn't be creating project cards for them so I'm wondering what the reasoning was?

If the reason is because we are reading in a log-file with calculated properties, then we should just ignore those properties as that would probably be a lot quicker than doing a bunch of GIS joins and we are starting to have issues with performance.

Lasso/lasso/project.py

Line 231 in 6bdfecc

base_roadway_network.create_calculated_variables()

@e-lo e-lo added the question Further information is requested label Jun 10, 2020
@i-am-sijia
Copy link
Member

@e-lo Because Lasso was used to write out project cards for base network correction, e.g. John found links with assign_group to be corrected in his QA/QC process.

@e-lo e-lo self-assigned this Jun 10, 2020
@e-lo
Copy link
Collaborator Author

e-lo commented Jun 10, 2020

Ok. - Since this seems to be taking a bunch of time I'm going to make this an optional flag.

@e-lo e-lo changed the title ? Do we need "calculated variables" to create project card? Don't need "calculated variables" to be calculated every time we create project card. Jun 10, 2020
e-lo added a commit that referenced this issue Jun 11, 2020
@e-lo
Major project changes refactor
5d4b603 
- Project changes now broken out into a few methods.
- More error catching and general robustness in project creation/ log file processing methods.
- Doesn't do geo calculations by default but can do if flagged with a keyword (Fixes #81 )
-  Added tests for csv and shp project changes read-in

TODO:
- Update test csv and shp files to be regular fields (not calculated)
- Add test for new util method
- Do some testing to make sure errors are obvious for all likely problematic inputs.
@e-lo
Copy link
Collaborator Author

e-lo commented Jun 11, 2020

Should work now. St Paul network read in for project card creation is a couple seconds on my laptop.

@e-lo e-lo closed this as completed Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-lo e-lo

@i-am-sijia i-am-sijia

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e-lo @i-am-sijia