allow passing an instance method to be_delayed matcher #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it easier to test that a Rails Mailer mail got delayed
|
no idea why this has a failing spec on jruby only? |
|
@philostler, it would be great if this could get merged and released. It's really helpful and fixes #53. |
|
@jschroeder9000 I never merged it due to the test failure. I'll have to try and find some time to check out this branch and see why this failure happens on JRuby |
philostler
pushed a commit
that referenced
this pull request
Jun 3, 2015
allow passing an instance method to be_delayed matcher
philostler
pushed a commit
that referenced
this pull request
Jun 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make it easier to test that a Rails Mailer mail got delayed
I'm not sure how to write a spec for this without adding ActiveMailer as a dependency?