Add support for calculating free-free continuum emission #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…mperature as a property
|
Closes #28 |
|
The free-bound calculation is now fully implemented, but does not match well at all with the equivalent calculation in CHIANTI IDL. In particular, a lot of the high-temperature emission seems to be missing. Not yet clear what the issue is. In the image below, the fiasco calculation is shown in the top panel and the IDL calculation in the bottom panel.
|
|
Merging and opening a separate issue/PR for free-bound continuum |
wtbarnes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for computing free-free and free-bound continuum emission. It closes #23.
Additionally, this PR adds a speedup for listing ions and is especially useful when creating collections of many ions which is currently slow.